rename purge_tags_header config to cache_tags_header #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
great job, really like this!
looking over the thing, i noticed that i would prefer this name for the config. the meaning of the header is cache tags, not purging.
also added a bit more explanation for the tagging.
a note on the default header name: these days, the recommendation is to omit the
X-
from custom headers. but for FOSHttpCache we in the end decided its too much hassle for too little benefit to refactor everything to drop them. this means that the default value will not work, because we still useX-Cache-Tags
. but i think we can handle this in the doc. its better if you have a clean thing here in this new library.