Add test for hit after expired should refresh cache #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
bugfix/hit-after-expired
branch
from
b05d9db to
1eb614d
Compare
alexander-schranz
force-pushed
the
bugfix/hit-after-expired
branch
from
1eb614d to
eeae3d3
Compare
|
Imho I don't think it's correct to merge this test here as we're testing the cache behaviour which should be done by Symfony and not by this libary :) |
|
@Toflar is okay for me :) |
|
Thanks for debugging the issue though! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After tracking it down it seems to be a symfony/cache issue: symfony/symfony#36458