Skip to content

Add optional reply-to support to tag command #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DevSerendipity
Copy link
Contributor

@DevSerendipity DevSerendipity commented Dec 16, 2021

Adds the optional support to /tag to reply-to users, they will then be mentioned:

image

This implements and closes #276 .

@DevSerendipity DevSerendipity requested review from a team as code owners December 16, 2021 13:51
@Zabuzard Zabuzard changed the title Option mentioning user Add optional reply-to support to tag command Dec 16, 2021
@Zabuzard Zabuzard added enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Dec 16, 2021
@Zabuzard Zabuzard added this to the Improvement phase 1 milestone Dec 16, 2021
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2022

CLA assistant check
All committers have signed the CLA.

@DevSerendipity
Copy link
Contributor Author

DevSerendipity commented Jan 8, 2022

Could someone explain to me why we can't use

mentionUserOption.getAsMember().getAsMention() which gives no warnings opposite to

mentionUserOption.getAsUser().getAsMention()

@Zabuzard
Copy link
Member

This cant be merged with the current git history. For some reason it has commits in it that shouldnt belong in here (for example a commit by Yusuf adding the warn command). Please rebase on develop and clean up your history so that it only has the changes that you actually made in this PR and nothing else.

In the worst case, just reset-mixed and then create a new commit with the now-reset changes.

@DevSerendipity
Copy link
Contributor Author

This cant be merged with the current git history. For some reason it has commits in it that shouldnt belong in here (for example a commit by Yusuf adding the warn command). Please rebase on develop and clean up your history so that it only has the changes that you actually made in this PR and nothing else.

In the worst case, just reset-mixed and then create a new commit with the now-reset changes.

The problem started when I pulled all the changes from my fork and rebased the origin developer branch. I wanted to resolve the merge conflict 2 days ago and when i pulled all those changes, i forgot that it pulled it to my feature/command-reply user branch and commited it.

Yesterday I tried with @Tais993 to roleback commits since i pushed all those changes, and it didn't sadly work.

@DevSerendipity DevSerendipity force-pushed the feature/command-reply-user branch from f37302f to b0a6578 Compare January 18, 2022 19:15
Adding the reply-to command
@DevSerendipity DevSerendipity force-pushed the feature/command-reply-user branch from 2aedca4 to ed7d97e Compare January 19, 2022 16:45
@Zabuzard Zabuzard dismissed stale reviews from illuminator3 and Tais993 January 19, 2022 16:50

done

@illuminator3 illuminator3 merged commit c908e26 into Together-Java:develop Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag command should support replying to users
5 participants