Adding help thread auto archiver #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
previously approved these changes
Aug 27, 2022
* added "handleRequireOverviewChannel" helper to reduce code duplication
Zabuzard
force-pushed
the
feature/auto_archive_help_threads
branch
from
596f7c2 to
7d8e2f6
Compare
|
Merging this, seems to be fine - if not, we can act afterwards. Want to accelerate development for this, need to get out a release for all the major improvements. Also, its weekened and I want to code a bit 😄 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Discord did some changes to the auto-archive system. They now only hide a channel after the set period and archive it only later (a week). That is a problem for us, since we relied on automatic archival after 24h for our help threads. Without it, they pile up and UX goes down.
Solution
Since Discord does not automatically close our channels properly anymore, we do it ourselves.
This PR adds a simple routine that periodically checks all help threads and archives them if there was no message sent since 24h.
Other
While at it, added a utility for the
handleRequireOverviewChannelfunctionality that has been duplicated around 5 times.Same with
getActiveThreadsInwhich also has been duplicated a couple of times.Tests
The solution is well tested. Here are some edge cases (the archive period has been set to 2 minutes for testing):
Keep it alive by sending messages
Reopen after close
