Add @MethodsReturnNonnullByDefault #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"database" subproject also has those annotations. Maybe create a separate subproject that will hold that annotation? This way "application" and "database" won't have to depend on each other. |
|
auto merging this on the weekend if no approves come in sooner 👍 |
Zabuzard
force-pushed
the
feature/methods_return_non_null_by_default
branch
from
17e0c73 to
5c7367e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #548. Similar to #541, this adds an annotation
@MethodsReturnNonnullByDefaultto all packages.Effectively making
@Nonnullcompletely obsolete in our code base - hence also removing it everywhere.The annotation is self-written (idea snacked from Minecraft who has this annotation as well - credits go to Quinteger for raising awareness).
The PR will of course generate a lot of (simple) merge conflicts - again. But I think people will like it 👍
Everyone say goodbye to
@Nonnull👋