Skip to content

Bugfix command completion not working #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2022

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Sep 30, 2022

In BotCore:
Added onCommandAutoCompleteInteraction listener, this way autocompletion events will actually get forwarded.

Funny, didnt think of this during the previous PR, was probably too hasty.

(maybe this was all planned for free commits \s

In BotCore:
Added onCommandAutoCompleteInteraction listener, this way autocompletion events will actually get forwarded.

Funny, didnt think of this during the previous PR, was probably too hasty.
@Tais993 Tais993 added bug Something isn't working priority: normal labels Sep 30, 2022
@Tais993 Tais993 self-assigned this Sep 30, 2022
@Tais993 Tais993 requested review from a team as code owners September 30, 2022 21:51
@Taz03
Copy link
Member

Taz03 commented Oct 1, 2022

works, tested it 👍

Tais993 and others added 2 commits October 1, 2022 07:55
…em/BotCore.java

Co-authored-by: Tanish Azad <73871477+Taz03@users.noreply.github.com>
@Taz03 Taz03 self-assigned this Oct 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Tais993 Tais993 requested a review from Zabuzard October 2, 2022 17:31
Copy link
Contributor

@illuminator3 illuminator3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tais993 Tais993 merged commit 1b2de09 into develop Oct 2, 2022
@Tais993 Tais993 deleted the bugfix/autocompletion-not-working branch October 2, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants