Link/Image previews for tags #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
added
enhance command
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
force-pushed
the
feature/tag_link_preview
branch
from
0072c45 to
5b5e75b
Compare
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days. |
yikes. ill have a look again 😬 |
Zabuzard
force-pushed
the
feature/tag_link_preview
branch
from
5b5e75b to
17ffde3
Compare
Zabuzard
force-pushed
the
feature/tag_link_preview
branch
from
707a9fd to
9ba00ea
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
8 days since last change, merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #270 by implementing automatic link and image previews to the
/tagcommand.Image only preview:
Link preview:
Utility
This feature is also available as general purpose utility via the
LinkPreviewsclass, yielding recordsLinkPreview.The utility offers two methods:
static List<String> extractLinks(String content)static CompletableFuture<List<LinkPreview>> createLinkPreviews(List<String> links)Features like #637 will likely make use of this as well.
Dependencies
Adds
io.github.url-detector:url-detector:0.1.23to the deps. URL regex is not something we want to have in our own code base lol.Also adds JSoup for the OpenGraph/Twitter meta-extraction.
Checklist
possibly unit tests(not today)