Skip to content

Report Command #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Nov 10, 2022
Merged

Report Command #653

merged 26 commits into from
Nov 10, 2022

Conversation

DevSerendipity
Copy link
Contributor

@DevSerendipity DevSerendipity commented Oct 24, 2022

Commands which redirects command called from Guild to a dedicated channel in Config#getModAuditLogChannelPattern()

Example steps on how it performs and UI it has.

image

When the report action clicked it starts a modal which looks like this

image

When it gets submmited it replies to the user and forwards the message to a dedicated channel called modmail.

image

And the message reported message consist of

  • Reported message,
  • Reported message URL and
  • Modal message

Which looks like this

image

@DevSerendipity DevSerendipity requested review from a team as code owners October 24, 2022 06:29
@DevSerendipity DevSerendipity self-assigned this Oct 24, 2022
@DevSerendipity DevSerendipity linked an issue Oct 24, 2022 that may be closed by this pull request
@DevSerendipity DevSerendipity added new command Add a new command or group of commands to the bot priority: normal labels Oct 24, 2022
Copy link
Contributor

@Nxllpointer Nxllpointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big nono. The message content and url are not allowed to be a field. Imagine a second user reporting something while the current user is typing in the modal. The Strings will be overwritten. Instead pass them as arguments in generateComponentId() for your modal.

@DevSerendipity
Copy link
Contributor Author

Big nono. The message content and url are not allowed to be static. Imagine a second user reporting something while the current user is typing in the modal. The Strings will be overwritten. Instead pass them as arguments in generateComponentId() for your modal.

Its still needs to pass the build, I am fixing that

@Nxllpointer
Copy link
Contributor

Ok 👌

Copy link
Contributor

@Nxllpointer Nxllpointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Great job! Almost everything is very easy to understand.

@Nxllpointer
Copy link
Contributor

Also instead of writing Done every time you can click the Resolve conversation button

@DevSerendipity
Copy link
Contributor Author

Also instead of writing Done every time you can click the Resolve conversation button

Zabuzard doesn't like when someone else resolves his convos

@DevSerendipity
Copy link
Contributor Author

Done.

@DevSerendipity
Copy link
Contributor Author

Done 2#

@DevSerendipity
Copy link
Contributor Author

Done 3#

Zabuzard
Zabuzard previously approved these changes Nov 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard dismissed stale reviews from Tais993 and Nxllpointer November 10, 2022 09:37

has been done

@DevSerendipity DevSerendipity merged commit 9e40327 into develop Nov 10, 2022
@DevSerendipity DevSerendipity deleted the feature/reportCommand branch November 10, 2022 09:42
@Zabuzard Zabuzard mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Add a new command or group of commands to the bot priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a report command
5 participants