-
-
Notifications
You must be signed in to change notification settings - Fork 95
Report Command #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report Command #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big nono. The message content and url are not allowed to be a field. Imagine a second user reporting something while the current user is typing in the modal. The Strings will be overwritten. Instead pass them as arguments in generateComponentId() for your modal.
Its still needs to pass the build, I am fixing that |
Ok 👌 |
...ication/src/main/java/org/togetherjava/tjbot/commands/moderation/modmail/ModMailCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/package-info.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/report/ReportCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Great job! Almost everything is very easy to understand.
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
Also instead of writing |
Zabuzard doesn't like when someone else resolves his convos |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
Done. |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
Done 2# |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
Done 3# |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
d2d85a0
to
8cf465a
Compare
Kudos, SonarCloud Quality Gate passed! |
Commands which redirects command called from Guild to a dedicated channel in Config#getModAuditLogChannelPattern()
Example steps on how it performs and UI it has.
When the report action clicked it starts a modal which looks like this
When it gets submmited it replies to the user and forwards the message to a dedicated channel called modmail.
And the message reported message consist of
Which looks like this