Updated nan to v2.2.0. #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any plans to merge this PR and make a new release? Is there anything that I can do to help? or #64 actually, which seems more comprehensive and up to date than this one! |
|
This was covered by #64 and is released as 1.2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was encountering an error when building node-lame on my Raspberry Pi 2 using node v5.5.0:
error: ‘v8::HandleScope::HandleScope()’ is protected
After some digging, it seemed like an update to nan would resolve the issue. Updated to v2.2.0. Tests pass. Node-lame now builds successfully on the Pi with node v5.5.0.