Issues about empty <key /> tag

[xiangpingmeng]

Generally, a typical plist file may has dictionary:

<key>some key</key>
<string>some value</string>
<key>some key</key>
<string>some value</string>
<key>some key</key>
<string>some value</string>

It is contains some key and values. but I recently work with some real plist files and they has empty tags, for example(such empty key from the Info.plist file .ipa package from AppStore):

<key />
<string />
<key>some key</key>
<string>some value</string>
<key>some key</key>
<string>some value</string>

as a result, this let plist.js parse failed. I check the source code in lib/parse.js in ths project:

//...
 else if (node.nodeName === 'key') {
    return node.childNodes[0].nodeValue;

  }
//...

It clear that node.childNodes[0].nodeValue not check the length of node.childNodes.

As result, if such empty key has encountered, the whole program will crash because index of out bounds error.

So, I think if we could let such index check more safely.

[agoldis]

+1

[MSLaguana]

We've just been bitten by this same issue: microsoft/vscode-cordova#58. Any idea when you'll be publishing the fix to npm?

[otmezger]

possible duplicated to #79. The fix proposed there fixed the problem for me.