-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #110
Update README.md #110
Conversation
I propose such solution for ToothlessGear#70 No need to make it more complex. Let's keep it simple.
Great! Thanks for the PR. I have a few notes:
|
Uh, and one small thing: we should try and be consistent with the code style. The other examples use this for error checking/logging: if(err) console.error(err);
else console.log(result); You should probably use this to be consistent :) |
Second update according to @hypesystem wishes.
Done, as you pleased. I'm not that convinced to be so consistent. For me, it implies too much Ctrl+C > Ctrl+V bad practice but whatever. I believe you can merge it now. |
Great! Remember to add yourself to the contributors list in package.json and in the README - then I'll merge :) Just a note on the consistency of code style (that you comment on): the code people first see, using the library, will probably use the style that they will themselves adopt. I think it's significant what we show new users of the library. Does it have to be this particular convention? No. But showing them that we stick to a convention fosters a better mentality (and more readable code). |
Added my nick to contributors list.
Added my name.
Done, you can merge ;) |
Update README.md to make it essier to understand how to use the library.
Sorry for the long wait - I got hit by the flu :( |
I propose such solution for #70 No need to make it more complex. Let's keep it simple.