merge vesin dependency declaration #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughReplaced two separate dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (39)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CompRhys
reviewed
Sep 17, 2025
pyproject.toml
Outdated
| "torch>=2", | ||
| "tqdm>=4.67", | ||
| "vesin-torch>=0.3.7", | ||
| "vesin-torch>=0.3.8", |
There was a problem hiding this comment.
Should also update the line below?
There was a problem hiding this comment.
why do we need to bump this pin? won't the dependency solver just work for 2.8 now a 2.8 compatible version exists if the end user has a 2.8 pin?
There was a problem hiding this comment.
I guess the user can explicitly decide to specify a version of vesin that they desire
There was a problem hiding this comment.
on another note, I looked at https://luthaf.fr/vesin/latest/index.html and they recommend using vesin[torch]. Maybe we should update this to be vesin[torch]>=0.3.7 so we don't accidentally update one but not the other?
curtischong
changed the title
|
merging into single fixup PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The vesin page recommends using vesin[torch] to install torchscript bindings https://luthaf.fr/vesin/latest/index.html.
This also reduces the chance of updating one version but forgetting to update the other
Checklist
Before a pull request can be merged, the following items must be checked:
We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run
pip install pre-commit && pre-commit installto install the hooks which will check your code before each commit.Summary by CodeRabbit