Skip to content

fix: faulty click area because of padding on invalid element #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix: faulty click area because of padding on invalid element #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e7e3b
fix(select): faulty click area with padding on invalid DOM element
TotomInc Sep 19, 2024
e2f36f0
fix(docs): update CSS variables on styling page
TotomInc Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/styling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ List of available CSS variables (pulled from the demo):
--vs-option-disabled-color: #f4f4f5;
--vs-option-disabled-text-color: #52525b;

--vs-multi-value-gap: 4px;
--vs-multi-value-gap: 0px;
--vs-multi-value-padding: 4px;
--vs-multi-value-margin: 4px 0px 4px 6px;
--vs-multi-value-font-size: 14px;
--vs-multi-value-font-weight: 400;
--vs-multi-value-line-height: 1;
Expand Down
8 changes: 5 additions & 3 deletions src/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,9 @@ onBeforeUnmount(() => {
--vs-option-disabled-color: #f4f4f5;
--vs-option-disabled-text-color: #52525b;

--vs-multi-value-gap: 4px;
--vs-multi-value-gap: 0px;
--vs-multi-value-padding: 4px;
--vs-multi-value-margin: 4px 0px 4px 6px;
--vs-multi-value-font-size: 14px;
--vs-multi-value-font-weight: 400;
--vs-multi-value-line-height: 1;
Expand Down Expand Up @@ -602,7 +603,6 @@ onBeforeUnmount(() => {
align-items: center;
flex-basis: 100%;
flex-grow: 1;
padding: var(--vs-padding);

&.multi {
gap: var(--vs-multi-value-gap);
Expand All @@ -612,6 +612,7 @@ onBeforeUnmount(() => {
.single-value {
display: flex;
align-items: center;
padding: var(--vs-padding);
font-size: var(--vs-font-size);
font-weight: var(--vs-font-weight);
font-family: var(--vs-font-family);
Expand All @@ -626,7 +627,7 @@ onBeforeUnmount(() => {
align-items: center;
gap: var(--vs-multi-value-gap);
padding: var(--vs-multi-value-padding);
margin: 0;
margin: var(--vs-multi-value-margin);
border: 0;
font-size: var(--vs-multi-value-font-size);
font-weight: var(--vs-multi-value-font-weight);
Expand All @@ -653,6 +654,7 @@ onBeforeUnmount(() => {
padding: 0;
border: 0;
background: none;
padding: var(--vs-padding);
font-size: var(--vs-font-size);
font-family: var(--vs-font-family);
line-height: var(--vs-line-height);
Expand Down