fix: add tag slot for multi-select #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @rudokemper, I've had to make some minor tweaks. See this MR: #135 I've co-authored the commit with you to ensure you get credits 🙂 |
|
Awesome! Great to see it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128.
This PR adds a
#tagslot with access to bothoptionandremoveOption()values, and documents this tag option in Vitepress.I've also adapted the Playground code to implement this slot as a demo; I thought that might be helpful. But this may not be desired, I'm happy to revert that change if so.
I hope I did this right - it was my first time setting up a Vue slot template! Let me know if any adjustments are needed.