Refactor plugin integrations into subpackage #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
reviewed
Oct 16, 2021
src/main/java/com/gmail/goosius/siegewar/integration/cannons/CannonsListener.java
Outdated
Show resolved
Hide resolved
LlmDl
requested changes
Oct 16, 2021
|
Changes look good, I'll give it another look over/review tomorrow. |
LlmDl
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves SiegeWar's external integrations (currently with Dynmap and Cannons) into a new subpackage. Additionally, the main plugin class has been refactored to allow this, and to be more consistent with Towny.
(In preparation of PR adding Pl3xMap support)
New Nodes/Commands/ConfigOptions:
N/A
Relevant Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.