Close on complete in GrpcScheduler #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GrpcScheduler fails to close the downstream Receiver when the upstream one completes. This causes it to hang forever even though its completed. Fixes TraceMachina#323
chrisstaite-menlo
force-pushed
the
close_grpc_scheduler
branch
from
f5943c3
to
d7f6ea3
Compare
|
Tests not available due to #154. |
allada
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
We really need some GRPC testing framework :-(
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)
blakehatch
pushed a commit
to blakehatch/nativelink
that referenced
this pull request
Nov 14, 2023
The GrpcScheduler fails to close the downstream Receiver when the upstream one completes. This causes it to hang forever even though its completed. Fixes TraceMachina#323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GrpcScheduler fails to close the downstream Receiver when the upstream one completes. This causes it to hang forever even though its completed.
Fixes #323
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Using a GrpcScheduler in front of a SimpleScheduler to a Reclient.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is