Skip to content

Fix add_remote_user when run without AuthenticationMiddleware. Fix #86 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2018
Merged

Fix add_remote_user when run without AuthenticationMiddleware. Fix #86 #92

merged 3 commits into from
Aug 22, 2018

Conversation

mccalluc
Copy link
Contributor

(#86 is an issue I filed, so it might not be the direction you want to take the project, or you might see other problems with this.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2011cb on mccalluc:master into ddf67fc on TracyWebTech:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2011cb on mccalluc:master into ddf67fc on TracyWebTech:master.

@coveralls
Copy link

coveralls commented Aug 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0648812 on mccalluc:master into ddf67fc on TracyWebTech:master.

@brianmay
Copy link
Collaborator

I see no problem with this change. Fix the flake8 error and I will merge...

I would also suggest adding to the documentation that add_remote_user does nothing without AuthenticationMiddleware.

@brianmay brianmay merged commit 6ba9b1d into jazzband:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccalluc @coveralls @brianmay