Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: french translation #555

Merged
merged 29 commits into from
Apr 1, 2024
Merged

docs: french translation #555

merged 29 commits into from
Apr 1, 2024

Conversation

AminGtt
Copy link
Contributor

@AminGtt AminGtt commented Feb 15, 2024

All the configs are good, ALL the pages has been imported and the non-translated ones are commented & got a "WIP" on first line (The comments in the code snippets has been removed because they were creating bugs with global comments).

Just remove comments & translate the remaining pages should complete the job 🎉
I'll continue on my side too 🔨
Cheers

@AminGtt AminGtt self-assigned this Feb 15, 2024
@AminGtt AminGtt changed the title Docs/translation fr docs: french translation Feb 15, 2024
Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are a lot of errors in the translation. French isn't my first language though. I'll leave it up to a first-language French speaker to look over.

docs/fr/guide/your-first-scene.md Outdated Show resolved Hide resolved
docs/fr/guide/your-first-scene.md Outdated Show resolved Hide resolved
@Laeti-dev
Copy link
Contributor

@alvarosabu I made a proof reading of the guide's french version. Could I get some permission to push my corrections ? Thank you

@alvarosabu
Copy link
Member

@Laeti-dev done

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 3b2b3b6
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/660a56b119ced4000814fd1b
😎 Deploy Preview https://deploy-preview-555--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Laeti-dev
Copy link
Contributor

thank you @alvarosabu

@AminGtt
Copy link
Contributor Author

AminGtt commented Feb 26, 2024

Hey everyone, sorry for the delay I was off for few days.
Big thanks to everybody for the help and the evolution. I'll take a look in depth asap.
Cheers!

@alvarosabu alvarosabu added docs Improvements or additions to documentation i18n labels Mar 6, 2024
@alvarosabu
Copy link
Member

Hi @AminGtt @Laeti-dev thanks for taking care of this. We recently merged the Cookbook section #557 so we will need to update the PR.

Steps:

The .md files under the examples directory are the same ones used in the cookbook, so just rename the directory from fr/examples to fr/cookbook.

If you have any questions or you need help with this, let me know 🙏🏻

@AminGtt
Copy link
Contributor Author

AminGtt commented Mar 25, 2024

Hello everyone, we're getting getting closer! The PR will go in review ASAP (probably tomorrow)🥳
@alvarosabu I followed the request you made about cookbook, everything should be good to go. Tell me if you see anything wrong.
Cheers!

@AminGtt
Copy link
Contributor Author

AminGtt commented Mar 26, 2024

Hey @alvarosabu I hope you're doing good!
I finished the FR translation for all the pages, I think a review would be nice. Then how do you want to proceed for the next steps?
Keep me posted,
Cheers!

@alvarosabu
Copy link
Member

Hey @AminGtt, doing good thanks 😊, pretty excited about this one.

Seems like there is a conflict with latest main that needs to be sorted out, let me know if you need help with that.

@andretchen0 dunno if you want to review this one before we merge?

@andretchen0
Copy link
Contributor

Hey @alvarosabu

@andretchen0 dunno if you want to review this one before we merge?

French is my second language. I read it and speak it, but I can't correct it.

@AminGtt
Copy link
Contributor Author

AminGtt commented Mar 28, 2024

Everything seems clear on my side, keep me posted about how it will go 🥳

@AminGtt AminGtt requested a review from alvarosabu March 31, 2024 12:05
@alvarosabu
Copy link
Member

Amazing job everyone 👏🏻 I can't thank you enough @AminGtt @Laeti-dev @andretchen0

@alvarosabu alvarosabu merged commit 669f7fe into main Apr 1, 2024
7 checks passed
@alvarosabu alvarosabu deleted the docs/translation-fr branch April 1, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation i18n
Projects
Status: Done
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants