-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: french translation #555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there are a lot of errors in the translation. French isn't my first language though. I'll leave it up to a first-language French speaker to look over.
@alvarosabu I made a proof reading of the guide's french version. Could I get some permission to push my corrections ? Thank you |
@Laeti-dev done |
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thank you @alvarosabu |
Hey everyone, sorry for the delay I was off for few days. |
Hi @AminGtt @Laeti-dev thanks for taking care of this. We recently merged the Cookbook section #557 so we will need to update the PR. Steps: The .md files under the examples directory are the same ones used in the cookbook, so just rename the directory from
If you have any questions or you need help with this, let me know 🙏🏻 |
Hello everyone, we're getting getting closer! The PR will go in review ASAP (probably tomorrow)🥳 |
Hey @alvarosabu I hope you're doing good! |
Hey @AminGtt, doing good thanks 😊, pretty excited about this one. Seems like there is a conflict with latest main that needs to be sorted out, let me know if you need help with that. @andretchen0 dunno if you want to review this one before we merge? |
Hey @alvarosabu
French is my second language. I read it and speak it, but I can't correct it. |
Everything seems clear on my side, keep me posted about how it will go 🥳 |
Amazing job everyone 👏🏻 I can't thank you enough @AminGtt @Laeti-dev @andretchen0 |
All the configs are good, ALL the pages has been imported and the non-translated ones are commented & got a "WIP" on first line (The comments in the code snippets has been removed because they were creating bugs with global comments).
Just remove comments & translate the remaining pages should complete the job 🎉
I'll continue on my side too 🔨
Cheers