fix: Implement createComment and nextSibling nodeOps
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects being v-if'd are not lost by Vue's runtime and incorrectly placed in the scene root
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
garrlker
changed the title
createComment and nextSibling nodeOpscreateComment and nextSibling nodeOps
garrlker
changed the title
createComment and nextSibling nodeOpscreateComment and nextSibling nodeOps
Closed
5 tasks
andretchen0
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Hey @garrlker ,
Thanks for the fix. Looks good! 👍
As discussed on Discord, I'll leave the TODO up to you.
I've pushed a playground for v-if along with some basic components for showing tests in playground pages.
This was referenced Jun 7, 2024
andretchen0
added a commit
that referenced
this pull request
Jun 7, 2024
alvarosabu
pushed a commit
that referenced
this pull request
Jun 12, 2024
#726) * refactor: add 'is' module/tests * refactor: push predicates down into functions * refactor: pass TresContext to nodeOps * refactor: remove predicates/optional chaining, use is/context * chore: lint * refactor: use unknown type, not any * fix: re-add changes from #717 * refactor: use uknown type, not any * refactor: use uknown type, not any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #706
When a component is set to not render with
v-if, Vue willcreateComment("v-if")Then when that component's
v-ifis set to true again, VuecreateElementto re-create that componentWe were not implementing
v-ifso Vue did not have a placeholder comment to keep track ofv-if'dobjects positions.When it called
createElementsince there was no parent, we were placing it at the scene rootI'm wonder if this has not been working the entire time and none of us noticed?