Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Fix a bug of find widget #377

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix a bug of find widget #377

merged 1 commit into from
Aug 30, 2024

Conversation

SiriusXT
Copy link
Member

@SiriusXT SiriusXT commented Aug 30, 2024

When finding, if you delete a find result in the note and then click to find the next one, an error will occur:

CKEditorError: mapping-model-position-view-parent-not-found {"modelPosition":{"root":"$graveyard","path":[0],"stickiness":"toNext"}}
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-mapping-model-position-view-parent-not-found
    at Nc.on.priority (<anonymous>:6:643867)
    at Nc.fire (<anonymous>:6:470940)
    at Nc.toViewPosition (<anonymous>:6:646343)
    at Nc.toViewRange (<anonymous>:6:646082)
    at n_.<anonymous> (<anonymous>:6:1032187)
    at m (<anonymous>:6:602325)
    at f (<anonymous>:6:602550)
    at p (<anonymous>:6:602439)

This pr makes it necessary to update the find results after modifying a note and then clicking on Find Previous and Next.

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eliandoran eliandoran merged commit b116362 into TriliumNext:develop Aug 30, 2024
@eliandoran eliandoran added this to the v0.90.5-beta milestone Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants