Bloodworms 28017

[Lorenc95]

Description:

2018-08-23_19:44:01 ERROR [misc.movesplineinitargs] MoveSplineInitArgs::Validate: expression 'velocity >= 0.01f' failed for GUID: 0 Entry: 28017

Current behaviour:
Error in worldserver.

CHANGEME Tell us what happens.
Whenever a Deathknight is in a dungeon and his bloodworms are attacking the error is spammed in the world server for about 5 or 6 times.

Expected behaviour:
No messages should be spammed.

CHANGEME Tell us what should happen instead.
Mentioned above

Steps to reproduce the problem:
Play a blood deathknight and the above message will be triggered when bloodworms are being used in a dungoen.

Branch(es):
3.3.5

TC rev. hash/commit:
50f70a3

Operating system: WIN64

F.Y.I. : the message comes from this part of the source:

TrinityCore/src/server/game/Movement/Spline/MoveSpline.cpp

Lines 198 to 212 in 50f70a3

	bool MoveSplineInitArgs::Validate(Unit* unit) const
	{
	#define CHECK(exp) \
	if (!(exp))\
	{\
	TC_LOG_ERROR("misc.movesplineinitargs", "MoveSplineInitArgs::Validate: expression '%s' failed for GUID: %u Entry: %u", #exp, unit->GetTypeId() == TYPEID_PLAYER ? unit->GetGUID().GetCounter() : unit->ToCreature()->GetSpawnId(), unit->GetEntry());\
	return false;\
	}
	CHECK(path.size() > 1);
	CHECK(velocity >= 0.01f);
	CHECK(time_perc >= 0.f && time_perc <= 1.f);
	//CHECK(_checkPathBounds());
	return true;
	#undef CHECK
	}

Last updated by @Aokromes, but he only "Fine tuned another log" in commit e1cbd2c
@ariel- made commit 2e68736 "Corrected all speed checks after 23b6991" (which in turn was @Keader's update).

So maybe one of them has got ideas about how to fix that error message.

[Keader]

My change was based in Shade of Akama encounter, where Shade of Akama can have velocity below 0.1f
Looks like @Ovahlord found some encounters with velocity below 0.01f, so, this check need update

[Ovahlord]

There are indeed some game parts where the velocity can go below 0.01f. The Plants vs. Zombies questline for example has super slow zombies that can be slowed even further.

[Lorenc95]

Im pretty sure the check was not added with the consideration there are creatures going under 0.1 velo, i guess a check for negative numbers would do?

[Aokromes]

that check was 0.1 then we found some under 0.1 moved to 0.01 it looks not enough.

[Ovahlord]

It is 0.01 already. It can be even smaller tho.

[Lorenc95]

Set to 0.01 resulted in no more errors.

[Faq]

@yvomsx you meant 0.001?

[Lorenc95]

Yes correct, 0.001 my bad.

[jackpoz]

f1f0576