Skip to content

Conversation

devilcoredev
Copy link
Contributor

No description provided.

@Shocker
Copy link
Contributor

Shocker commented Feb 23, 2012

Any specific utility of this hook?

@devilcoredev
Copy link
Contributor Author

In my case for example many talents should check if the caster has the aura's talent. For example for Focus Magic that persists after the caster unlearns the talent but there are other cases.

@Shocker
Copy link
Contributor

Shocker commented Feb 23, 2012

That could be done in the TalentsReset hook, creating an aura update hook for that is not the best idea.

@devilcoredev
Copy link
Contributor Author

Mmm, is there a TalentsReset hook?

@Subv
Copy link
Contributor

Subv commented Feb 24, 2012

In PlayerScript there is something similar to TalentsReset

@devilcoredev
Copy link
Contributor Author

There is "OnTalentsReset" in PlayerScript but it's not called when the player switches the spec through http://www.wowhead.com/spell=63645 or http://www.wowhead.com/spell=63644.

@Shocker
Copy link
Contributor

Shocker commented Feb 24, 2012

Switch spec can/should be considered a talents reset, the OnTalentsReset should be triggered on spec change too IMHO

@devilcoredev
Copy link
Contributor Author

Even if we solve this problem, there is another problem: the Focus Magic isn't applied on the caster, so you cannot get the aura pointer in the hook "OnTalentsReset" because all units don't register the auras applied on other units...

@JasperAppec
Copy link

Using a PlayerScripts here would be hacky anyway..

@Subv
Copy link
Contributor

Subv commented Feb 25, 2012

@devilcoredev they do

@devilcoredev
Copy link
Contributor Author

No, they don't, they only register the single target auras, but the other types of auras aren't registered.

@Warpten
Copy link
Contributor

Warpten commented Feb 25, 2012

apart from this, i do believe giving a hook on every world update tick is a bad idea, it seems more logical to try to have as few update hooks as possible.

@devilcoredev
Copy link
Contributor Author

Ok, any idea for get all auras casted by a unit?

@Faq
Copy link
Contributor

Faq commented Jul 15, 2012

i guess, this should be closed. AS PR code is refused. Discussion should be made at other place if needed.
none responded in long time anyway, so why keep PR alive?

@DDuarte DDuarte closed this Jul 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants