-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Implemented hook OnUpdate on AuraScript called when the aura is updated. #5385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any specific utility of this hook? |
In my case for example many talents should check if the caster has the aura's talent. For example for Focus Magic that persists after the caster unlearns the talent but there are other cases. |
That could be done in the TalentsReset hook, creating an aura update hook for that is not the best idea. |
Mmm, is there a TalentsReset hook? |
In PlayerScript there is something similar to TalentsReset |
There is "OnTalentsReset" in PlayerScript but it's not called when the player switches the spec through http://www.wowhead.com/spell=63645 or http://www.wowhead.com/spell=63644. |
Switch spec can/should be considered a talents reset, the OnTalentsReset should be triggered on spec change too IMHO |
Even if we solve this problem, there is another problem: the Focus Magic isn't applied on the caster, so you cannot get the aura pointer in the hook "OnTalentsReset" because all units don't register the auras applied on other units... |
Using a PlayerScripts here would be hacky anyway.. |
@devilcoredev they do |
No, they don't, they only register the single target auras, but the other types of auras aren't registered. |
apart from this, i do believe giving a hook on every world update tick is a bad idea, it seems more logical to try to have as few update hooks as possible. |
Ok, any idea for get all auras casted by a unit? |
i guess, this should be closed. AS PR code is refused. Discussion should be made at other place if needed. |
No description provided.