Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorized MetaFairClassifier and removed unused code #196

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Vectorized MetaFairClassifier and removed unused code #196

merged 2 commits into from
Feb 12, 2021

Conversation

hoffmansc
Copy link
Collaborator

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request introduces 2 alerts and fixes 22 when merging 240d23e into e267a8d - view on LGTM.com

new alerts:

  • 2 for Unused local variable

fixed alerts:

  • 8 for Unused import
  • 5 for Unused local variable
  • 3 for Module is imported with 'import' and 'import from'
  • 3 for Variable defined multiple times
  • 2 for 'import *' may pollute namespace
  • 1 for Loop variable capture

@hoffmansc hoffmansc mentioned this pull request Aug 13, 2020
Merged
@hoffmansc
Copy link
Collaborator Author

@nrkarthikeyan is this okay to merge? I think this will fix the Travis errors for pending PRs

hoffmansc added a commit that referenced this pull request Oct 13, 2020
@hoffmansc
Skip slow meta fair test
2667991 
Stopgap for #196
@hoffmansc hoffmansc mentioned this pull request Oct 13, 2020
Merged
hoffmansc added a commit that referenced this pull request Oct 14, 2020
@hoffmansc
Skip slow meta fair test (#208)
b9f7e15 
Stopgap for #196
@nrkarthikeyan
Copy link
Collaborator

@vijaykeswani would you mind taking a quick look at this?

@vijaykeswani
Copy link
Contributor

@nrkarthikeyan I took a pass and it looks good. @hoffmansc Thanks for the changes.

@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2020

This pull request introduces 2 alerts and fixes 22 when merging 5abde89 into ec48af4 - view on LGTM.com

new alerts:

  • 2 for Unused local variable

fixed alerts:

  • 8 for Unused import
  • 5 for Unused local variable
  • 3 for Module is imported with 'import' and 'import from'
  • 3 for Variable defined multiple times
  • 2 for 'import *' may pollute namespace
  • 1 for Loop variable capture

@nrkarthikeyan nrkarthikeyan merged commit 6e64e03 into master Feb 12, 2021
@hoffmansc hoffmansc deleted the meta_fair_cleanup branch February 15, 2021 15:08
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@hoffmansc
Skip slow meta fair test (Trusted-AI#208)
de6b8f7 
Stopgap for Trusted-AI#196
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@nrkarthikeyan
Merge pull request Trusted-AI#196 from Trusted-AI/meta_fair_cleanup
130b849 
Vectorized MetaFairClassifier and removed unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrkarthikeyan nrkarthikeyan nrkarthikeyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoffmansc @nrkarthikeyan @vijaykeswani