Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Revert "Update ember-one-way-controls to version 1.1.1 🚀" #273

Merged

Conversation

kevinansfield
Copy link
Member

Reverts #252

Using this version of ember-one-way-controls results in a bug that prevents the spacebar working when editing post titles.

I'm not sure if it's related to our own code or the addon but reverting to the known-working version for now.

@acburdine acburdine merged commit e432af7 into master Sep 20, 2016
@acburdine acburdine deleted the revert-252-greenkeeper-ember-one-way-controls-1.1.1 branch September 20, 2016 13:05
@kevinansfield
Copy link
Member Author

This issue sounds similar to DavyJonesLocker/ember-one-way-controls#119 - we trim the input value using sanitizeInput which the update action then passes back through the passed-in value resulting in spaces at the end of the input text always being lost.

yo1dog pushed a commit to yo1dog/Ghost-Admin that referenced this pull request Oct 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants