This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Fix for broken image upload button #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
suggested changes
Jul 2, 2017
app/components/gh-markdown-editor.js
Outdated
| @@ -311,7 +311,7 @@ export default Component.extend(ShortcutsMixin, { | |||
| delete this._onEditorPaneScroll; | |||
| }, | |||
|
|
|||
| _openImageFileDialog({captureSelection = true}) { | |||
| _openImageFileDialog(captureSelection = true) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
patrickskim
force-pushed
the
patch-1
branch
2 times, most recently
from
bacd550
to
a0b48fe
Compare
Removed superfluous curly braces. Fixes TryGhost/Ghost#8637
|
Hi Kevin, thanks for reviewing. I looked into both methods suggested. I think setting a default value is the correct approach as it encourages consistent usage while remaining open to the usage of named params in the future. Made changes to reflect. |
kevinansfield
approved these changes
Jul 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8637
_openImageFileDialogargs so that destructuring with default params works when not passed a value