Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image button not working in editor #8637

Closed
biswajit-saha opened this issue Jun 26, 2017 · 0 comments · Fixed by TryGhost/Admin#766
Closed

Image button not working in editor #8637

biswajit-saha opened this issue Jun 26, 2017 · 0 comments · Fixed by TryGhost/Admin#766
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with

Comments

@biswajit-saha
Copy link

biswajit-saha commented Jun 26, 2017 •
edited
Loading

Issue Summary

After clicking on image button in the post editor nothing is happening and there is an Uncaught TypeError
in console.

####Error in console

Uncaught TypeError: Cannot read property 'captureSelection' of undefined            ghost-388d636….js:2604 
_openImageFileDialog @ ghost-388d636….js:2604
action               @ ghost-388d636….js:2383
el.onclick           @ vendor-cdc3808….js:155879

Steps to Reproduce

  1. Go to editor and point cursor in text edit area
  2. Click on the image icon in editor toolbar

Technical details:

  • Ghost Version: v1.0.0-beta.2 ( local install )
  • Node Version: 6.11.0
  • Browser/OS: Chrome / Ubuntu
  • Database: sqlite3

screenshot from 2017-06-27 02 24 45
@acburdine acburdine added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with labels Jun 26, 2017
@PaszaVonPomiot PaszaVonPomiot mentioned this issue Jun 28, 2017
Closed
patrickskim pushed a commit to patrickskim/Ghost-Admin that referenced this issue Jul 2, 2017
@patrickkim
Fix for broken image upload button
50eec0f 
Removed superfluous curly braces.
Fixes TryGhost/Ghost#8637
@patrickskim patrickskim mentioned this issue Jul 2, 2017
Merged
patrickskim pushed a commit to patrickskim/Ghost-Admin that referenced this issue Jul 3, 2017
@patrickkim @patrickskim
Fix for broken image upload button
bacd550 
Removed superfluous curly braces.
Fixes TryGhost/Ghost#8637
patrickskim pushed a commit to patrickskim/Ghost-Admin that referenced this issue Jul 3, 2017
@patrickkim @patrickskim
Fix for broken image upload button
a0b48fe 
Removed superfluous curly braces.
Fixes TryGhost/Ghost#8637
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Jul 4, 2017
@patrickkim @kevinansfield
🐛 fix broken image upload button (#766)
bace776 
closes TryGhost/Ghost#8637
- add a default object to `_openImageFileDialog` args so that destructuring with default params works when not passed a value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for broken image upload button patrickskim/Ghost-Admin
3 participants
@kevinansfield @acburdine @biswajit-saha