Added configuration controller to v2 API #10056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
df7ec90
to
e18df61
Compare
12 tasks
rishabhgrg
changed the title
naz
reviewed
Oct 29, 2018
core/server/api/v2/configuration.js
Outdated
| @@ -0,0 +1,67 @@ | |||
| const Promise = require('bluebird'), | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
naz
reviewed
Oct 29, 2018
| request; | ||
|
|
||
| describe('Configuration API', function () { | ||
| var accesstoken = '', ghostServer; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Other than some non-crucial improvements it's good to 🚢 |
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
e18df61
to
f2cd3d5
Compare
kirrg001
changed the title
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
9867021
to
49cabc0
Compare
|
@rishabhgrg could u please update this one? would love to clean up our PR list :) |
rishabhgrg
changed the title
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
49cabc0
to
048d6ef
Compare
rishabhgrg
changed the title
kirrg001
reviewed
Dec 3, 2018
| function getBaseConfig() { | ||
| return { | ||
| useGravatar: !config.isPrivacyDisabled('useGravatar'), | ||
| publicAPI: labs.isSet('publicAPI'), |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
reviewed
Dec 3, 2018
| @@ -0,0 +1,11 @@ | |||
| const debug = require('ghost-ignition').debug('api:v2:utils:serializers:output:mail'); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
approved these changes
Dec 3, 2018
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
d9d62a6
to
f0e99fc
Compare
rishabhgrg
force-pushed
the
configuration-ctrl-v2
branch
from
f0e99fc
to
0d80e39
Compare
allouis
added a commit
that referenced
this pull request
Dec 4, 2018
* master: Version bump to 2.7.0 Updated Ghost-Admin to 2.7.0 🐛 Fixed contributors being able to delete draft posts as co-author (#10239) Added configuration controller to v2 API (#10056) 🐛 Fixed site changed webhook not triggered for scheduled posts 🐛 Fixed invalid imported subscribers count (#10229) 🐛Fixed auto redirect for extra data queries on post and page resources (#9828) Included relations if static resource is post | page (#10148) Renamed API -> Api for v2 auth logic (#10142) 🐛Removed user reference warning from importer report if post is a draft (#10169) 🐛 Fixed edit permission of the common article by multiple authors (#10214) Updated npm keywords (#10217)
allouis
added a commit
that referenced
this pull request
Dec 7, 2018
* master: Version bump to 2.7.1 Updated Ghost-Admin to 2.7.1 Version bump to 2.7.0 Updated Ghost-Admin to 2.7.0 🐛 Fixed contributors being able to delete draft posts as co-author (#10239) Added configuration controller to v2 API (#10056) 🐛 Fixed site changed webhook not triggered for scheduled posts 🐛 Fixed invalid imported subscribers count (#10229) 🐛Fixed auto redirect for extra data queries on post and page resources (#9828) Included relations if static resource is post | page (#10148) Renamed API -> Api for v2 auth logic (#10142) 🐛Removed user reference warning from importer report if post is a draft (#10169) 🐛 Fixed edit permission of the common article by multiple authors (#10214) Updated npm keywords (#10217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #10060