Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting within inline code markup breaks markdown "undo" #10717

Closed
kevinansfield opened this issue Apr 29, 2019 · 2 comments
Closed

Formatting within inline code markup breaks markdown "undo" #10717

kevinansfield opened this issue Apr 29, 2019 · 2 comments
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Member

kevinansfield commented Apr 29, 2019 •
edited
Loading

Issue Summary

When an inline code markup has additional formatting applied, pressing Backspace at the end of the markup only removes code markup back to the end of the last markup.

code-markups

To Reproduce

  1. See screencast above

Technical details:

  • Ghost Version: 2.21.0
  • Browser/OS: Chrome/macOS
@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor affects:admin Anything relating to Ghost Admin labels Apr 29, 2019
@kevinansfield
Copy link
Member Author

kevinansfield commented Apr 29, 2019 •
edited
Loading

Note: This only occurs if the code markup is the first markup within a section.

Similarly, pressing Backspace whilst the cursor is at the beginning of the first code markup in the section triggers the de-expansion rather than appending the section to the previous section.

code-markups-2

@kevinansfield kevinansfield mentioned this issue Apr 29, 2019
Closed
@kevinansfield
Copy link
Member Author

The initial issue is an upstream bug in mobiledoc-kit. Issue opened here bustle/mobiledoc-kit#676

kevinansfield added a commit to TryGhost/Admin that referenced this issue Apr 29, 2019
@kevinansfield
Fixed backspace not combining sections if first section is a special …
25eae72 
…markup

refs TryGhost/Ghost#10717 (comment)
- avoid triggering special markup delete behaviour when cursor is at the beginning of a section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinansfield