Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkmarks next to tiers benefits that have been filled in have incorrect background colour in dark mode #18872

Closed
1 task done
stromfeldt opened this issue Nov 6, 2023 · 2 comments
Closed
1 task done

Checkmarks next to tiers benefits that have been filled in have incorrect background colour in dark mode #18872

stromfeldt opened this issue Nov 6, 2023 · 2 comments
Labels
affects:admin Anything relating to Ghost Admin design P3 - Medium [triage] Bugs which we'll fix soon

Comments

@stromfeldt
Copy link
Contributor

stromfeldt commented Nov 6, 2023 •
edited
Loading

Issue Summary

As the title says, checkmarks next to tiers benefits that have been filled in have incorrect background colour in dark mode.

EDIT: This was with the free tier, I don't know whether or not this also occurs with paid tiers.

Xnapper-2023-11-06-16 50 50

Steps to Reproduce

  1. Navigate to Tiers while in dark mode
  2. Add a benefit
  3. See that the background of the checkmark to the filled-in-benefit has the incorrect background colour

Ghost Version

5.71.2+moya

Node.js Version

Yes

How did you install Ghost?

Ghost(Pro)

Database type

MySQL 5.7

Browser & OS version

Firefox 119, macOS 13.6

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 6, 2023
@daniellockyer daniellockyer added design affects:admin Anything relating to Ghost Admin and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Nov 6, 2023
@peterzimon peterzimon added the P3 - Medium [triage] Bugs which we'll fix soon label Nov 6, 2023
@Akhi88S
Copy link

Akhi88S commented Nov 11, 2023

yes @stromfeldt, background color as showing in following capture is causing the issue here.
Screenshot 2023-11-11 at 4 59 03 PM

Hey @daniellockyer @peterzimon, can you please assign the issue to me.

@Akhi88S Akhi88S mentioned this issue Nov 12, 2023
Closed
@dvdwinden dvdwinden mentioned this issue Dec 11, 2023
Merged
peterzimon added a commit to peterzimon/Ghost that referenced this issue Dec 11, 2023
@peterzimon
Fixed bg color of tiers icon
edcf949 
fixes TryGhost#18872
dvdwinden added a commit that referenced this issue Dec 11, 2023
@dvdwinden
Fixed white icon bg's in tier list in dark mode
cfde713 
Closes issue #18872

Solves the problem of the bg-white class showing a white background behind the checkmark icons in the tier list.
dvdwinden added a commit that referenced this issue Dec 11, 2023
@dvdwinden
Fixed white icon bg's in tier list in dark mode (#19310)
8c5c773 
Closes issue #18872

Solves the problem of the bg-white class showing a white background
behind the checkmark icons in the tier list.
@dvdwinden
Copy link
Contributor

Hi @stromfeldt,

Thank you for reporting this issue — it should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin design P3 - Medium [triage] Bugs which we'll fix soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[18872] checkmarks background fix in tiers benefits section Akhi88S/Ghost
5 participants
@peterzimon @daniellockyer @dvdwinden @stromfeldt @Akhi88S