Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Code Formatting in Callout Card #19129

Closed
1 task done
0xBEN opened this issue Nov 25, 2023 · 3 comments · Fixed by TryGhost/Koenig#1135
Closed
1 task done

Inline Code Formatting in Callout Card #19129

0xBEN opened this issue Nov 25, 2023 · 3 comments · Fixed by TryGhost/Koenig#1135
Assignees
Labels
P3 - Medium [triage] Bugs which we'll fix soon

Comments

@0xBEN
Copy link

0xBEN commented Nov 25, 2023

Issue Summary

Issue Synopsis

In previous versions of Ghost -- prior to upgrading to 5.74.3 -- inline code was formatted as expected in callout cards. Upon upgrading to the latest version, the inline code formatting still displays as expected in the editor view. However, when reading the published article, the formatting of the inline code is lost, and the inline code appears as plain text. This makes it difficult to emphasize and distinguish code and/or commands in callout cards.

Inline code formatting in callout cards was last known to be working for me in Ghost 5.59.

Screenshots

Callout Card with Code in Ghost 5.74.3 Editor

image

Callout Card in Ghost 5.74.3 Published Article

image

Callout Card in Google Cache (Ghost 5.59)

image

Steps to Reproduce

  1. Create a new post or update an existing one
  2. Add a new callout card or update an existing one
  3. Add some text to the callout card, as well as one or many inline code blocks. Inline code blocks are created by wrapping text between backticks. `inline code example` == inline code example
  4. Note that the inline code appears to be formatted correctly within the callout card
  5. Publish or update the post, then open the published post
  6. Note that the inline code formatting in the callout card does not match what's shown in the editor

Ghost Version

5.74.3

Node.js Version

18.17.1

How did you install Ghost?

Followed self-hosting guidance, Ubuntu 22.04

Database type

MySQL 8

Browser & OS version

Google Chrome 119.0.6045.160

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 25, 2023
@kevinansfield kevinansfield added P3 - Medium [triage] Bugs which we'll fix soon and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Nov 25, 2023
@btme0011
Copy link

Can i work on this issue?

@kevinansfield kevinansfield self-assigned this Dec 12, 2023
kevinansfield added a commit to kevinansfield/Koenig that referenced this issue Dec 12, 2023
closes TryGhost/Ghost#19129

- callout card renderer has a whitelist of allowed tags in it's inner HTML content, this was missing some of our supported inline formats such as inline code
kevinansfield added a commit to TryGhost/Koenig that referenced this issue Dec 12, 2023
closes TryGhost/Ghost#19129

- callout card renderer has a whitelist of allowed tags in it's inner HTML content, this was missing some of our supported inline formats such as inline code
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Dec 12, 2023
refs TryGhost#19129

- bumps Koenig packages containing fix for callout card rendering
kevinansfield added a commit that referenced this issue Dec 12, 2023
refs #19129

- bumps Koenig packages containing fix for callout card rendering
@0xBEN
Copy link
Author

0xBEN commented Jan 12, 2024

Hello, I'm not sure if this is the proper workflow, or if you'd rather a new issue that references this one. However, this issue still seems to be ongoing. I've updated my Ghost instance to the latest version and still and not able to have inline code elements rendered within a callout card.

image

@kevinansfield
Copy link
Member

The fix hasn't been released yet. It will appear in the release notes when it's included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 - Medium [triage] Bugs which we'll fix soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants