Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Upload: Upload in editor panel #40

Closed
6 tasks done
ErisDS opened this issue May 18, 2013 · 4 comments
Closed
6 tasks done

Image Upload: Upload in editor panel #40

ErisDS opened this issue May 18, 2013 · 4 comments
Assignees
@cobbspur
Milestone
0.3

Comments

@ErisDS
Copy link
Member

ErisDS commented May 18, 2013

Requires: Issue #280: Image Upload: Reusable tool for uploads

The image upload drop zone which appears in the preview panel should allow the user to upload images.

See the wiki for the user story.

  • If the user drops an image on the drop zone then that image should be uploaded.
  • An image should be any file with a .gif, .jpg or .png extension.
  • If the user clicks anywhere in the drop zone except for the two icons, then a file dialog should be shown. Any file selected should also be uploaded as described. Note: This behaviour may have to downgrade in some browsers.
  • Images should be uploaded to the /content/images directory. Images should be organised into year & month directories as in WordPress.
  • While the image is uploading, the progress and any errors should be displayed as defined by issue Image upload interaction design #38.
  • Once the image is uploaded, it should replace the entirety of the image upload drop zone.
@ghost ghost assigned cobbspur May 18, 2013
@ErisDS ErisDS mentioned this issue May 18, 2013
Closed
@cobbspur
Copy link
Member

To keep a track of things:

  • If the user drops an image on the drop zone then that image should be uploaded.
  • An image should be any file with a .gif, .jpg or .png extension.
  • If the user clicks anywhere in the drop zone except for the two icons, then a file dialog should be shown. Any file selected should also be uploaded as described. Note: This behaviour may have to downgrade in some browsers.
  • Images should be uploaded to the /content/images directory. Images should be organised into year & month directories as in WordPress.
  • While the image is uploading, the progress and any errors should be displayed as defined by issue Image upload interaction design #38.
  • Once the image is uploaded, it should replace the entirety of the image upload drop zone.

@cobbspur
Copy link
Member

FF issues, progress bar very jumpy, currently click on dragzone does not open file dialogue

This was referenced Jul 14, 2013
Closed
Closed
@ErisDS ErisDS mentioned this issue Aug 2, 2013
Closed
@cobbspur cobbspur mentioned this issue Aug 5, 2013
Merged
cobbspur added a commit to cobbspur/Ghost that referenced this issue Aug 5, 2013
@cobbspur
Added image upload reusable plugin
558c9d6 
issue TryGhost#40 and issue TryGhost#280

- Adds uploader jquery plugin
- includes settings for enabling/disabling upload progress bar
- adds routing for image uploads
- adds directories by year and month based on upload date
- Implements plugin on settings - general pane
- Implements plugin on editor
- adjusted general tab to save uploaded image src

TODO:
- Add error handling
- Storing information on editor
- Add events
@ErisDS
Copy link
Member Author

ErisDS commented Aug 22, 2013

I think, with a couple more amends this one is pretty much ready to be closed?

@ErisDS
Copy link
Member Author

ErisDS commented Aug 29, 2013

I think that as of #547 this one is closable

@ErisDS ErisDS closed this as completed Aug 29, 2013
@neilstuartcraig neilstuartcraig mentioned this issue Nov 17, 2013
Closed
@novaugust novaugust mentioned this issue Sep 27, 2014
Closed
@snyk-bot snyk-bot mentioned this issue Mar 29, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cobbspur cobbspur

Labels
None yet
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
2 participants
@ErisDS @cobbspur