-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Model: Review max length limits in database schema #4134
Comments
Max length for slugs is arbitrary. I don't think there shuold be a limit. We've run into the slugs not being long enough here: https://ghost.org/forum/using-ghost/16161-how-to-change-the-slug-to-include-only-year-and-month I propose to extend that to 512 or even 1024 char lengths. Currently it's 150. |
@javorszky At the same time the title length should be reconsidered. It currently has a limit of 150 characters as well.
|
Slugs are one thing which can have a pretty restrictive limit without negative consequence. We should simply trim them automatically for both readability and usability. It's also an SEO enhancement (source). I agree title length should be less restrictive |
Google says (source, march 7, 2014, source of source) that you should keep urls shorter than 2,000 chars, but there's no theoretical limit. Would definitely help with 301 redirects in that you only need to swap the domains and not cater for regex trimming urls. |
|
Let's move the limit to 255 then? :) |
Closing this as it's effectively covered by #7432 and we don't need 2 issues open :) |
Some of the max length limits in the database schema need extending.
With regard to meta_title and meta_description, see: #4126 (comment)
While we're at it, it's worth reviewing all of the max length limits now that we have more information about how people use their blogs.
For all of the "text" fields that don't have a clear answer to how long they should be, we need a plan for:
We don't get to change these things later, only thing we can easily do is increase a soft (validated) limit
So it needs to be right, and future proof
In order to implement the changes, we will need #601 - the ability to change the max length on a column.We're going to make these changes as part of the alpha
The text was updated successfully, but these errors were encountered: