Bug: Subscribers import can fail to load last line

[cobbspur]

Issue Summary

During a subscribers CSV import, if the CSV file does not end with a newline, the final line is not included.

Steps to Reproduce

Make a column of a few email address in Google sheets.
Download as CSV (do not modify file - many editors automatically add a line)
Import CSV on /ghost/subscribers/

Result is 1 less imported email address than the CSV

[kirrg001]

It only affects CSV files without column headers. Can you confirm?
If so, i have a fix in mind and will care.

[cobbspur]

No, If there are no column headers you get the error - Column header missing: "email"

The readline module looks for a new line - (\r, \n, \r\n) before returning 'line' which means the read stream ends but the final line is not returned. We could perhaps read the whole stream first and check/append a new line at the end then read this line by line.

[sebgie]

FYI: nodejs/node-v0.x-archive#7238 it's a bug in Node 0.10, fixed in 0.12 and there is a suggestion for a workaround.

[kirrg001]

Thanks @sebgie
In my opinion this is a low priority bug, because 1. nothing crashes and the feature still works 2. only 0.10 is affected 3. only one subscriber is not imported

If somebody is interested in this bug fix, pick it up 👍

[cobbspur]

👍 confirmed issue is resolved on node v4

[ErisDS]

Node 0.10 is still our recommended version and the version running on Ghost(Pro). Although that will be changing soon, I'd like to see a workaround for this go into the next release.