Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post title oddities in 1.0 alpha editor #7754

Closed
1 of 2 tasks
acburdine opened this issue Nov 29, 2016 · 5 comments
Closed
1 of 2 tasks

Post title oddities in 1.0 alpha editor #7754

acburdine opened this issue Nov 29, 2016 · 5 comments
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@acburdine
Copy link
Member

acburdine commented Nov 29, 2016

Issue Summary

After messing around with the Ghost 1.0-alpha editor for a bit, I discovered a couple of oddities that make it slightly more difficult to use.

  • Typing spaces in a post title does not work for new posts. (once the post has been saved it starts working again)

  • Typing two spaces in a row for post title of an existing post (one that has already been saved) results in a '.' being added to the title

    • I can understand why this is a thing for the editor itself, but it does seem odd to have it happen in the title.

Technical details:

  • Ghost Version: 1.0.0-alpha master (ghost-admin commit)
  • Node Version: 4.6
  • Browser/OS: Chrome 54
  • Database: Sqlite

/cc @disordinary

@acburdine acburdine added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Nov 29, 2016
@acburdine
Copy link
Member Author

Note: feel free to close this if the issues have been fixed on ghost-editor master - will check master of ghost-editor next time I get a chance.

@disordinary
Copy link
Contributor

Hey @acburdine,

That is odd, especially because the title is independent of the editor itself (it's just the same input control that was used with the old admin).
Development on the editor is on hold ATM but will be picked up again shortly, I know of plenty of issues but did not see that one 😄

@javorszky
Copy link
Contributor

Ah, my issue can fit in here!

If you have a title with spaces in it, and you start deleting the last word, as soon as the cursor would delete the first letter of the last word, it also automatically deletes the trailing space, which can be annoying if all you want to do is retype a word. See below.

broken_title_delete

@kevinansfield
Copy link
Contributor

@javorszky I think that may actually be solved in the current alpha due to this change made a couple of days ago https://github.com/TryGhost/Ghost-Admin/pull/475/files#diff-c92558c8ecbfb99450d1e16549e418b2. I'll open a more specific issue and mark it as LTS

disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 14, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Mar 14, 2017
refs TryGhost/Ghost#7754
- The title is now a contenteditable div which stretches and wraps to behave like the editor.
- It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.

Refs: TryGhost/Ghost#7754
@kevinansfield
Copy link
Contributor

I believe everything here is resolved now, I'm not able to replicate any of the issues on master.

kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Mar 21, 2017
refs TryGhost/Ghost#7754

The title is now a contenteditable div which stretches and wraps to behave like the editor.

It also tries to seemlessly move the cursor between the editor and title to make one coherent editing experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

4 participants