Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor - drag and drop #8315

Closed
disordinary opened this issue Apr 11, 2017 · 1 comment · Fixed by TryGhost/Admin#640
Closed

Editor - drag and drop #8315

disordinary opened this issue Apr 11, 2017 · 1 comment · Fixed by TryGhost/Admin#640
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@disordinary
Copy link
Contributor

disordinary commented Apr 11, 2017 •
edited
Loading

Issue Sumarry

Mobiledoc tracks drag and drop events which is preventing Firefox from supporting drag and drop image uploads.
firefox image drag and drop

Steps to Reproduce

  1. Edit a markdown card in Firefox.
  2. Drag an image from your computer onto the card.

Expected result

The image should insert an upload placeholder and when the upload has finished replace it with said upload.

chrome upload
@ErisDS ErisDS added affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly and removed affects:editor Work relating to the Koenig Editor labels Apr 11, 2017
@disordinary
Copy link
Contributor Author

Turns out it was an ember issue not mobiledoc.

This was referenced Apr 12, 2017
Merged
Closed
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Apr 13, 2017
@disordinary @kevinansfield
🐜 🎊 Fix firefox drag and drop support for image uploading in markdown…
14bbb0d 
… cards. (#640)

closes TryGhost/Ghost#8315
- Previously you couldn't upload images in markdown cards in firefox. Moving the drop action off of the component and onto the root editor as well as having an dragover handler which does nothing fixed the issue 🤷
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐜 🎊 Fix firefox drag and drop support in markdown cards. disordinary/Ghost-Admin
2 participants
@disordinary @ErisDS