Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown card sometimes stays in 'hard-select' mode when it has the cursor #8385

Closed
disordinary opened this issue Apr 25, 2017 · 0 comments · Fixed by TryGhost/Admin#674
Closed

Markdown card sometimes stays in 'hard-select' mode when it has the cursor #8385

disordinary opened this issue Apr 25, 2017 · 0 comments · Fixed by TryGhost/Admin#674
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@disordinary
Copy link
Contributor

Issue Summary

As mentioned here: #8379

When an editable card is in edit mode it should tell ghost that it should no longer be 'hard-selected', this means that Ghost no longer handles keyboard events like up, down, delete, backspace, enter, etc. and the editable card has full control.

The markdown card can have the cursor but stays in hard-select mode which means pressing delete or backspaced will remove it.

card-hard-mode

Steps to Reproduce

  1. Create a markdown card.
  2. Click Edit.
  3. If the border is thicker press delete.

Technical details:
@disordinary disordinary mentioned this issue Apr 25, 2017
Closed
@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Apr 25, 2017
@disordinary disordinary mentioned this issue Apr 25, 2017
Merged
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Apr 25, 2017
@disordinary @kevinansfield
🐛 fix backspace deleting cards whilst editing (#674)
f022295 
closes TryGhost/Ghost#8385
- If a card that is being edited is hard-selected then make sure that it is in fact soft-selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that editing cards are not hard-selected disordinary/Ghost-Admin
2 participants
@kevinansfield @disordinary