Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up markdown usages #8479

Closed
3 tasks done
kirrg001 opened this issue May 22, 2017 · 0 comments · Fixed by #8497
Closed
3 tasks done

Tidy up markdown usages #8479

kirrg001 opened this issue May 22, 2017 · 0 comments · Fixed by #8497
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin server / core Issues relating to the server or core of Ghost

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented May 22, 2017 •
edited by kevinansfield
Loading

For 1.0 we have added a mobiledoc database field and a mobiledoc converter.
The new editor (see TryGhost/Admin@4b48328) is using the new database field.

There is no need to keep the old markdown field, as well as the old legacy converter, see https://github.com/TryGhost/Ghost/blob/master/core/server/models/post.js#L236.

We would like to remove all markdown related code:
@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin optimisation server / core Issues relating to the server or core of Ghost labels May 22, 2017
kirrg001 added a commit to kirrg001/Ghost that referenced this issue May 22, 2017
@kirrg001
🐛 import images: markdown can be null
81be4e3 
refs TryGhost#5422

- the markdown field will be removed soon, see TryGhost#8479
- if you import images the importer crashes if markdown is null e.g. the welcome post has no markdown field anymore (results in null)
@kirrg001 kirrg001 mentioned this issue May 23, 2017
Closed
@kirrg001 kirrg001 changed the title 🎨 tidy up markdown usages Tidy up markdown usages May 23, 2017
@vickychijwani vickychijwani mentioned this issue May 23, 2017
Closed
29 tasks
@kirrg001 kirrg001 assigned aileen and kevinansfield and unassigned aileen May 25, 2017
@ErisDS ErisDS mentioned this issue May 29, 2017
Closed
8 tasks
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue May 30, 2017
@kevinansfield
🔥 remove markdown attribute from Post model
91f2ae7 
refs TryGhost/Ghost#8479
- remove unused `ed-image-manager` util
- remove `markdown` attribute from Post model
@kevinansfield kevinansfield mentioned this issue May 30, 2017
Merged
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue May 30, 2017
@kevinansfield @kirrg001
🔥 remove markdown attribute from Post model (#720)
6d9997c 
refs TryGhost/Ghost#8479

- remove unused `ed-image-manager` util
- remove `markdown` attribute from Post model
@kevinansfield kevinansfield mentioned this issue May 31, 2017
Merged
2 tasks
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue May 31, 2017
@kevinansfield
🔥 remove posts.markdown field
61d11a6 
closes TryGhost#8479
- removes `markdown` field from schema
- removes `legacyMarkdown` converter
- updates tests to work with `mobiledoc` field instead of `markdown` and adapt for mobiledoc HTML output where necessary
kirrg001 pushed a commit that referenced this issue May 31, 2017
@kevinansfield @kirrg001
🔥 remove posts.markdown field (#8497)
85496f4 
closes #8479

- removes `markdown` field from schema
- removes `legacyMarkdown` converter
- updates tests to work with `mobiledoc` field instead of `markdown` and adapt for mobiledoc HTML output where necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔥 remove posts.markdown field kevinansfield/Ghost
3 participants
@kevinansfield @kirrg001 @aileen