User invite duplication and broken errors #8692
Comments
refs TryGhost#8692 - protect invite endpoint
|
Good catch 👍 This only happens on the invite screen for me. I've pushed a PR. @kevinansfield The error handling need's improving, because no matter which error the api returns, the admin always shows:
In my case, the API returned a validation error saying |
|
I couldn't invite user with the same email address from team menu. |
|
try inviting a user other than your own : that worked out for me.. |
|
It didn't work for me: |
refs #8692 - protect invite endpoint
refs TryGhost/Ghost#8692 - fixes the guard on setup/three against inviting the owner user set up on setup/two (we were sending invites for every e-mail in the list rather than only valid e-mails) - adds a check to see if we get any invalid errors from the server and will show those separately to the `x emails failed to send` alert
|
With the server-side changes and the changes in TryGhost/Admin#786 I'm not sure what else is left to do here? It would be useful to know how the duplicate user was created in the first place - as @kirrg001 mentioned the only place this should have been possible was inviting the owner user on the setup/three invite screen which should now be fixed. I've not been able to invite an existing or invited user via the team screen. |
|
@kevinansfield to get exact steps you would need to ask @JohnONolan. However, I would guess at this happening after an import, inviting a user that was locked. |
|
I am not able to reproduce this with latest master. Closing - please re-open if you discover this again! |
refs TryGhost/Ghost#8692 - fixes the guard on setup/three against inviting the owner user set up on setup/two (we were sending invites for every e-mail in the list rather than only valid e-mails) - adds a check to see if we get any invalid errors from the server and will show those separately to the `x emails failed to send` alert
refs TryGhost/Ghost#8692 - fixes the guard on setup/three against inviting the owner user set up on setup/two (we were sending invites for every e-mail in the list rather than only valid e-mails) - adds a check to see if we get any invalid errors from the server and will show those separately to the `x emails failed to send` alert
|
In RC1 I just successfully imported a user, who had a pending invitation to the blog - no duplicate entry detected.
Then when I clicked on the accept invitation link in the email, I got redirected to the login screen The invitation still shows up in Ghost admin - but there is no way to accept it. |
|
@JohnONolan this has been resolved in master, the fix isn't in RC1 |
It turns out you can invite a user email address that already has an account (this should not be possible) - and if you do, then they get this really ugly error when they try to accept the invitation (there should be an english error here, in case a user tries to manually put in an email address which already exists):
The text was updated successfully, but these errors were encountered: