Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import bug: User images are not retained properly #8833

Closed
ErisDS opened this issue Aug 3, 2017 · 0 comments · Fixed by #8834
Closed

Import bug: User images are not retained properly #8833

ErisDS opened this issue Aug 3, 2017 · 0 comments · Fixed by #8834
Assignees
Labels
bug [triage] something behaving unexpectedly import / upgrade life-cycle stuff: Importing, exporting, upgrading and migrating

Comments

@ErisDS
Copy link
Member

ErisDS commented Aug 3, 2017

When importing from LTS, some user images are not retained properly. Have seen this on a couple of occasions where an image has gone missing and originally assumed it was gravatar not being imported.

However, it is actually the gravatar step on save running and in some cases, overwriting the user's image. E.g. if I import a user with my personal email address which is registered with gravatar, but that already has a non-gravatar image set, then my non-gravatar image is replaced with gravatar.

Note: this behaviour is a bit unexpected on a normal user save, not just import, but for now I'm going to fix the importer bug only. This is because users are currently migrating from LTS.

I will then raise a separate issue to spec different behaviour for user images with gravatar.

@ErisDS ErisDS added bug [triage] something behaving unexpectedly import / upgrade life-cycle stuff: Importing, exporting, upgrading and migrating labels Aug 3, 2017
@ErisDS ErisDS self-assigned this Aug 3, 2017
ErisDS added a commit to ErisDS/Ghost that referenced this issue Aug 3, 2017
closes TryGhost#8833

- Don't re-run gravatar check when importing users
kirrg001 pushed a commit that referenced this issue Aug 3, 2017
closes #8833

- Don't re-run gravatar check when importing users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [triage] something behaving unexpectedly import / upgrade life-cycle stuff: Importing, exporting, upgrading and migrating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant