✨ Custom post templates #9073
Merged
✨ Custom post templates #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
added a commit
to TryGhost/Admin
that referenced
this pull request
Sep 28, 2017
refs TryGhost/Ghost#9060, requires TryGhost/Ghost#9073 - add `{{gh-psm-template-select}}` component - allows selection of a custom template for a post if the active theme has custom templates - loads themes on render, only hitting the server if not already in the store - disables select if post slug matches a `post-*.hbs` or `page-*.hbs` template - adds `customTemplate` attr to `Post` model - adds `templates` attr to `Theme` model with CPs to pull out custom vs post/page override templates - add `.gh-select.disabled` styles to make disabled selects look visually disabled
kirrg001
force-pushed
the
custom-post-templates
branch
3 times, most recently
from
cc2def3
to
9c7c55f
Compare
|
Ready for testing! |
|
I tested this successfully with a custom template. Also changed the theme, which doesn't have this specific template and it falls back to the default |
kirrg001
commented
Oct 3, 2017
| @@ -34,5 +38,10 @@ module.exports = function toJSON(name, checkedTheme) { | |||
| } | |||
| } | |||
|
|
|||
| // CASE: if you want a JSON response for a single theme, which is not active. | |||
| if (_.find(themeResult, {active: true}) && active.get()) { | |||
| _.find(themeResult, {active: true}).templates = active.get().customTemplates; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
force-pushed
the
custom-post-templates
branch
2 times, most recently
from
34113bd
to
2a99504
Compare
ErisDS
reviewed
Oct 9, 2017
| templateList.unshift(postObject.custom_template); | ||
| if (themes.getActive() && !themes.getActive().hasTemplate(slugTemplate)) { | ||
| templateList.unshift(postObject.custom_template); | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
- @todo: reconsider 150 length
- i've added the basic logic to gscan on my branch - the changes there aren't final at all, just for testing
- @todo: permissions - return 404 of :name does not exist - right now it only returns the active theme hardcoded - API endpoint implementation (RAW)
- gscan extracts the custom templates
- ensure we return custom templates - take care if no active theme instance exists
- if custom_template exists, it has the highest priority
- same behaviour in Admin panel
A file which is 100 characters long, looks like custom-aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
kirrg001
force-pushed
the
custom-post-templates
branch
from
4fe3df6
to
5c21605
Compare
ErisDS
approved these changes
Oct 10, 2017
kevinansfield
added a commit
to TryGhost/Admin
that referenced
this pull request
Oct 10, 2017
refs TryGhost/Ghost#9060, requires TryGhost/Ghost#9073 - add `{{gh-psm-template-select}}` component - allows selection of a custom template for a post if the active theme has custom templates - loads themes on render, only hitting the server if not already in the store - disables select if post slug matches a `post-*.hbs` or `page-*.hbs` template - adds `customTemplate` attr to `Post` model - adds `templates` attr to `Theme` model with CPs to pull out custom vs post/page override templates - add `.gh-select.disabled` styles to make disabled selects look visually disabled
|
any documentation on this ? |
|
@wassimseif There is documentation on https://themes.ghost.org and a blog post, plus a help guide is coming early next week. If you have any suggestions for documentation improvements, say hello in slack 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9060
Please look at the single commits for context.
TODO