Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

İmage upload button not working any more #9300

Closed
mertcangokgoz opened this issue Dec 1, 2017 · 1 comment · Fixed by TryGhost/Admin#919
Closed

İmage upload button not working any more #9300

mertcangokgoz opened this issue Dec 1, 2017 · 1 comment · Fixed by TryGhost/Admin#919
Assignees
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@mertcangokgoz
Copy link
Contributor

mertcangokgoz commented Dec 1, 2017

Issue Summary

not upload while trying to upload images

Steps to Reproduce

1- Login Ghost admin area
2- Select any draft stories
3- continue writing and try image upload
4- see that the image is not loaded ant not uploaded

Technical details:

  • Ghost Version: 1.18.2
  • Node Version: 6.12.0
  • Browser/OS: Safari, Chrome and Firefox Latest Release
  • Database: MySQL
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Dec 2, 2017
closes TryGhost/Ghost#9300
- as of TryGhost@74428ef we reset the file input earlier in the actions chain, this was clearing the file references before the editor was triggering the upload. By converting the `FileList` to an `Array` before resetting the input we keep hold of the file references and the upload works again.
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Dec 2, 2017
@kevinansfield kevinansfield self-assigned this Dec 2, 2017
@kevinansfield
Copy link
Member

Sorry about this, bug is confirmed and there's a fix is ready for the next release. In the meantime a workaround is to drag and drop images onto the editor to upload them as that method still works.

kevinansfield added a commit to TryGhost/Admin that referenced this issue Dec 2, 2017
closes TryGhost/Ghost#9300
- as of 74428ef we reset the file input earlier in the actions chain, this was clearing the file references before the editor was triggering the upload. By converting the `FileList` to an `Array` before resetting the input we keep hold of the file references and the upload works again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants