-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undesirable behaviour when creating new title bars #9373
Labels
Comments
kevinansfield
added
affects:admin
Anything relating to Ghost Admin
bug
[triage] something behaving unexpectedly
labels
Jan 5, 2018
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jan 5, 2018
closes TryGhost/Ghost#9373 - using an `<a>` element to parse a URL does not behave as expected when the URL has special characters because the `host` attribute will show the Puny URL version. Eg. `exämple.com` will become `xn--exmple-cua.com` - `{{gh-navitem-url-input}}` was failing to manipulate the URL value because of the difference between the Puny URL encoded URL and the raw configured URL with unicode chars - uses the `URI` module that's bundled with the imported version of `google-caja` to parse the URL via regexes rather than relying on native browser parsing
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jan 5, 2018
closes TryGhost/Ghost#9373 - using an `<a>` element to parse a URL does not behave as expected when the URL has special characters because the `host` attribute will show the Puny URL version. Eg. `exämple.com` will become `xn--exmple-cua.com` - `{{gh-navitem-url-input}}` was failing to manipulate the URL value because of the difference between the Puny URL encoded URL and the raw configured URL with unicode chars - uses the `URI` module that's bundled with the imported version of `google-caja` to parse the URL via regexes rather than relying on native browser parsing
kirrg001
pushed a commit
to TryGhost/Admin
that referenced
this issue
Jan 7, 2018
…ers (#941) closes TryGhost/Ghost#9373 - using an `<a>` element to parse a URL does not behave as expected when the URL has special characters because the `host` attribute will show the Puny URL version. Eg. `exämple.com` will become `xn--exmple-cua.com` - `{{gh-navitem-url-input}}` was failing to manipulate the URL value because of the difference between the Puny URL encoded URL and the raw configured URL with unicode chars - uses the `URI` module that's bundled with the imported version of `google-caja` to parse the URL via regexes rather than relying on native browser parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue Summary
I have a domain with a special character. I don't know if the bug comes thought the special char, but when I want to add some navigation titles, javascript or something else add the domain name in my URI. I can't delete the added domain in the URI path. See my video below.
https://youtu.be/9Axi_okjflE
Steps to Reproduce
This is the first step
Run latest image from docker and use it about a domain with a special char.
This is the second step, etc.
Try to add some navigation titles in default layout.
Technical details:
The text was updated successfully, but these errors were encountered: