Fixes: #9584 Added exception when the import is a draft post as published_by is null #10169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnguneratne
changed the title
…null closes #9584 - Importer checks if any user reference is null. If the post is a draft published_by will be null and an error will be logged. - Adds an exception to skip logging an error in this case.
kirrg001
reviewed
Nov 15, 2018
allouis
added a commit
that referenced
this pull request
Dec 4, 2018
* master: Version bump to 2.7.0 Updated Ghost-Admin to 2.7.0 🐛 Fixed contributors being able to delete draft posts as co-author (#10239) Added configuration controller to v2 API (#10056) 🐛 Fixed site changed webhook not triggered for scheduled posts 🐛 Fixed invalid imported subscribers count (#10229) 🐛Fixed auto redirect for extra data queries on post and page resources (#9828) Included relations if static resource is post | page (#10148) Renamed API -> Api for v2 auth logic (#10142) 🐛Removed user reference warning from importer report if post is a draft (#10169) 🐛 Fixed edit permission of the common article by multiple authors (#10214) Updated npm keywords (#10217)
allouis
added a commit
that referenced
this pull request
Dec 7, 2018
* master: Version bump to 2.7.1 Updated Ghost-Admin to 2.7.1 Version bump to 2.7.0 Updated Ghost-Admin to 2.7.0 🐛 Fixed contributors being able to delete draft posts as co-author (#10239) Added configuration controller to v2 API (#10056) 🐛 Fixed site changed webhook not triggered for scheduled posts 🐛 Fixed invalid imported subscribers count (#10229) 🐛Fixed auto redirect for extra data queries on post and page resources (#9828) Included relations if static resource is post | page (#10148) Renamed API -> Api for v2 auth logic (#10142) 🐛Removed user reference warning from importer report if post is a draft (#10169) 🐛 Fixed edit permission of the common article by multiple authors (#10214) Updated npm keywords (#10217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9584
This PR adds an exception in core\server\data\importer\importers\data\base.js replaceIdentifiers() to skip adding a userReferenceProblem when the import is status: draft and user reference is published_by.