Members lib #10260
Merged
Members lib #10260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allouis
commented
Dec 10, 2018
|
|
||
| function getFreshState() { | ||
| const [hash, formType, query] = window.location.hash.match(/^#([^?]+)\??(.*)$/) || ['#signin?', 'signin', '']; | ||
| console.log({hash, formType, query}) |
There was a problem hiding this comment.
This needs removing
rishabhgrg
reviewed
Dec 10, 2018
| @@ -351,12 +352,14 @@ var config = require('./core/server/config'), | |||
| }, | |||
|
|
|||
| prod: { | |||
| 'core/client': 'shell:ember:prod' | |||
| 'core/client': 'shell:ember:prod', | |||
| 'core/server/lib/members/static/auth': 'shell:preact:prod' | |||
There was a problem hiding this comment.
This runs preact prod build to create dist folder with static bundle.
rishabhgrg
reviewed
Dec 10, 2018
| }, | ||
|
|
||
| watch: { | ||
| projects: { | ||
| 'core/client': ['shell:ember:watch', '--live-reload-base-url="' + urlService.utils.getSubdir() + '/ghost/"'] | ||
| 'core/client': ['shell:ember:watch', '--live-reload-base-url="' + urlService.utils.getSubdir() + '/ghost/"'], | ||
| 'core/server/lib/members/static/auth': ['shell:preact:dev'] |
There was a problem hiding this comment.
Runs watch and live reload for developing member auth views, probably one side-effect during local dev is it clears console once on start, this can be fixed in next iteration.
daniellockyer
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Added members library inc. gateway refs #10213 * Added the auth pages and build steps for them refs #10213 * Cleaned up logs * Updated gruntfile to run yarn for member auth * Design refinements on members popups * UI refinements * Updated backend call to trigger only if frontend validation passes * Design refinements for error messages * Added error message for email failure * Updated request-password-reset to not attempt to send headers twice * Updated preact publicPath to relative path * Build auth pages on init
daniellockyer
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Added members library inc. gateway refs #10213 * Added the auth pages and build steps for them refs #10213 * Cleaned up logs * Updated gruntfile to run yarn for member auth * Design refinements on members popups * UI refinements * Updated backend call to trigger only if frontend validation passes * Design refinements for error messages * Added error message for email failure * Updated request-password-reset to not attempt to send headers twice * Updated preact publicPath to relative path * Build auth pages on init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the core of the members lib