Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced 2.18 detection #10610

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Enhanced 2.18 detection #10610

merged 2 commits into from
Mar 13, 2019

Conversation

kirrg001
Copy link
Contributor

No description provided.

allouis
allouis reviewed Mar 13, 2019
View reviewed changes
core/server/data/migrations/versions/2.18/1-restore-settings-from-backup.js
@@ -13,6 +13,7 @@ module.exports.config = {

const backupFileRegex = /ghost.([\d]{4}-[\d]{2}-[\d]{2}).json$/;

// @NOTE: spagetthi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italia 🇮🇹

@allouis
Copy link
Contributor

allouis commented Mar 13, 2019

Looks good - I think we wanna get rid of the migrations variable we set from the backup, and the if checks around it

@kirrg001 kirrg001 changed the title [WIP] Enhanced 2.18 detection Enhanced 2.18 detection Mar 13, 2019
@kirrg001 kirrg001 merged commit a2f7160 into TryGhost:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allouis allouis allouis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kirrg001 @allouis