UPT: update and add default UTC timezone #10870 #11245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlphaWong
force-pushed
the
feature/update-moment-timezone
branch
from
f821c1e
to
6640fc6
Compare
4 tasks
|
Hi @AlphaWong, I really appreciate you taking the time to try to fix this issue, but the approach in this PR is not something we can agree to maintain. In Ghost, we set a global default, and moment-timezone needs to respect that. Having to remember to set it everywhere guarantees future timezone bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objective
update
moment-timezoneand set all related code to default UTC.reference
#10870