Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Removed list of reserved slugs #11301

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

kevinansfield
Copy link
Member

no issue

  • reserved slugs get in the way of creating pages such as /signin/ which do not currently exist and are useful for members
  • the reserved slugs concept is a little meaningless because if there are any route clashes then our own routes should always win out over a post slug

no issue

- reserved slugs get in the way of creating pages such as `/signin/` which do not currently exist and are useful for members
- the reserved slugs concept is a little meaningless because if there are any route clashes then our own routes should always win out over a post slug
@kevinansfield kevinansfield merged commit c2cdfef into TryGhost:master Oct 29, 2019
@kevinansfield kevinansfield deleted the remove-reserved-slugs branch October 29, 2019 09:49
kevinansfield added a commit that referenced this pull request Nov 18, 2019
refs #11301

- the reserved slugs list was emptied in #11301 but the empty array was left in place
- this cleans up all other references to reserved slugs so that the empty array can also be removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants