Cleaned up members isPaid flag in settings table
#11651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naz
added a commit
to naz/Ghost-Admin
that referenced
this pull request
Mar 10, 2020
refs TryGhost/Ghost#11651 - The flag is being removed from the backend, so can be safely removed on client as well
allouis
reviewed
Mar 10, 2020
core/server/data/migrations/versions/3.11/02-remove-legacy-is-paid-flag-from-settings.js
Outdated
Show resolved
Hide resolved
refs TryGhost#11650 - The flag is no longer used and can be removed to make the settings JSON easier to read
naz
force-pushed
the
members-clean-up-is-paid-flag
branch
from
8e51242
to
9efdd55
Compare
naz
commented
Mar 11, 2020
| paymentProcessor => paymentProcessor.adapter === 'stripe' | ||
| ); | ||
|
|
||
| if (stripePaymentProcessor && stripePaymentProcessor.config.public_token && stripePaymentProcessor.config.secret_token) { |
There was a problem hiding this comment.
@allouis does this logic make sense to you? Couldn't find any concrete reference to equivalent of this flag
There was a problem hiding this comment.
Might wanna doublecheck with @rishabhgrg who introduced the flag, too
There was a problem hiding this comment.
@gargol Think this is fine, isPaid was to mark if stripe setup is present or not so this should ideally cover it. 🤔
rishabhgrg
reviewed
Mar 12, 2020
core/server/data/migrations/versions/3.12/01-remove-legacy-is-paid-flag-from-settings.js
Show resolved
Hide resolved
rishabhgrg
approved these changes
Mar 12, 2020
daniellockyer
approved these changes
Mar 12, 2020
allouis
reviewed
Mar 12, 2020
core/server/data/migrations/versions/3.12/01-remove-legacy-is-paid-flag-from-settings.js
Outdated
Show resolved
Hide resolved
allouis
reviewed
Mar 12, 2020
| const settingsKey = 'members_subscription_settings'; | ||
|
|
||
| return localOptions | ||
| .transacting('settings') |
There was a problem hiding this comment.
Could this not be more specific like:
.transacting('settings')
.where('key', settingsKey)
.select('value')
.first()There was a problem hiding this comment.
True! I like it. Will redo the query 👍
allouis
approved these changes
Mar 12, 2020
rishabhgrg
approved these changes
Mar 13, 2020
allouis
approved these changes
Mar 13, 2020
daniellockyer
approved these changes
Mar 13, 2020
naz
added a commit
to naz/Ghost-Admin
that referenced
this pull request
Mar 16, 2020
refs TryGhost/Ghost#11651 - The flag is being removed from the backend, so can be safely removed on client as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #11650 spotted this flag and decided to do a lil cleanup while in the area.
The
isPaidflag is no longer used and can be removed to make the settings JSON easier to readTODO: