Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Updated fixtures to make it easier to get started #14299

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

matthanley
Copy link
Contributor

  • Our old fixtures were designed as a guide to getting started to Ghost, but they got in the way
  • The old fixtures now live as part of ghost.org/resources - a living guide to starting with Ghost
  • These new fixtures mean the site is ready to go as soon as it's setup

ErisDS and others added 3 commits March 10, 2022 17:14
- Our old fixtures were designed as a guide to getting started to Ghost, but they got in the way
- The old fixtures now live as part of ghost.org/resources - a living guide to starting with Ghost
- These new fixtures mean the site is ready to go as soon as it's setup
- After setup is completed we update our fixtures with site-specific data
- This is to help ensure that after setup is complete a site is ready to go, with no further amends required
- Added feature_image to initial _Coming soon_ post in fixtures
- Removed preceding slash from secondary nav link to Portal so it opens on the current page
- Removed GHOST_URL from mobiledoc to open Portal on the current page
@github-actions
Copy link
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #14299 (1bc22b0) into main (c4470ff) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14299      +/-   ##
==========================================
- Coverage   55.48%   55.45%   -0.03%     
==========================================
  Files         565      565              
  Lines       46860    46883      +23     
  Branches     3898     3898              
==========================================
  Hits        26001    26001              
- Misses      20820    20843      +23     
  Partials       39       39              
Impacted Files Coverage Δ
core/server/services/auth/setup.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4470ff...1bc22b0. Read the comment docs.

@matthanley matthanley merged commit 7172db7 into main Mar 10, 2022
@matthanley matthanley deleted the fixtures-2021 branch March 10, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants