🐛 Fixed issue where single letter product slugs cause 500 error #16821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost/Product#3224 When a product has a slug that is a single letter, checking if a user had access to view a post associated with that product would cause a 500 error. The underlying cause of this issue is TryGhost/NQL#20 This fix circumvents this issue by providing a value that the nql lexer will not error out on
naz
approved these changes
May 18, 2023
let's get it into main. nice find Mike!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #16821 +/- ##
=======================================
Coverage 72.26% 72.26%
=======================================
Files 1797 1797
Lines 113816 113816
Branches 17022 17022
=======================================
+ Hits 82251 82252 +1
+ Misses 30459 30458 -1
Partials 1106 1106
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/3224
When a product has a slug that is a single letter, checking if a user had access to view a post associated with that product would cause a 500 error. The underlying cause of this issue is TryGhost/NQL#20 This fix circumvents this issue by providing a value that the nql lexer will not error out on